feat(avatar): DLT-1916 remove dt-icon from Avatar vue 2 #474

ninamarina · 2024-08-26T20:28:55Z

Remove dt-icon from Avatar vue 2

🛠️ Type Of Change

These types will increment the version number on release:

Fix
Feature
Performance Improvement
Refactor

📖 Jira Ticket

DLT-1916

📖 Description

Vue 2 part of #466

💡 Context

Make Dialtone-vue tree shakeable

ninamarina · 2024-09-03T13:42:25Z

The tests that are breaking are not related to this changes, and will be fixed when merging #483

juliodialpad

Looking good! didn't had the opportunity to review the Vue 3 version, is it the same as this one? I saw a lot of code that could be improved here, if it's the same on the vue 3 version it'd be great to address this comments on Vue 3 too if possible please.

packages/dialtone-vue2/components/avatar/avatar.test.js

packages/dialtone-vue2/recipes/item_layout/contact_info/contact_info.vue

packages/dialtone-vue2/recipes/item_layout/contact_info/contact_info.stories.js

packages/dialtone-vue2/recipes/leftbar/contact_row/contact_row.vue

juliodialpad

After a careful review and testing I'm ok with the implementation of <component :is="" /> in this component to avoid more breaking changes and ease the usage of this component.

apps/dialtone-documentation/docs/components/avatar.md

packages/dialtone-vue2/recipes/leftbar/contact_row/contact_row.vue

packages/dialtone-vue3/components/avatar/avatar.test.js

packages/dialtone-vue3/recipes/leftbar/contact_row/contact_row.vue

packages/dialtone-vue2/recipes/item_layout/contact_info/contact_info.vue

github-actions · 2024-09-05T20:56:08Z

Please add either the visual-test-ready or no-visual-test label to this PR depending on whether you want to run visual tests or not.
It is recommended to run visual tests if your PR changes any UI. ‼️

Co-authored-by: Julio Ortega <[email protected]>

juliodialpad

Looks good! Apply the suggested change before merging please.

Don’t forget to update the docs if needed either on this PR or a new one.

packages/dialtone-vue2/recipes/item_layout/contact_info/contact_info.vue

…t_info.vue Co-authored-by: Julio Ortega <[email protected]>

github-actions · 2024-09-05T21:27:06Z

✔️ Deploy previews ready!
😎 Dialtone preview: https://dialtone.dialpad.com/deploy-previews/pr-474/
😎 Dialtone-vue 2 preview: https://dialtone.dialpad.com/vue/deploy-previews/pr-474/
😎 Dialtone-vue 3 the preview: https://dialtone.dialpad.com/vue3/deploy-previews/pr-474/

# [9.73.0-beta.2](dialtone/v9.73.0-beta.1...dialtone/v9.73.0-beta.2) (2024-09-12) ### Bug Fixes * **Lint:** NO-JIRA fix linter rule for text styles ([#494](#494)) ([c6b5f3f](c6b5f3f)) * **Scrollbar Directive:** NO-JIRA overlayscrollbars missing styles ([#493](#493)) ([d1a88e1](d1a88e1)) * **Tokens:** NO-JIRA keep references in css output ([#487](#487)) ([b019ff6](b019ff6)) ### Documentation * **Icon:** DLT-1916 update documentation to show tree shaking examples ([#491](#491)) ([5b9d969](5b9d969)) * NO-JIRA wrong dialtone-css import on local ([da5f7d6](da5f7d6)) ### Features * **Avatar:** DLT-1916 remove dt-icon from Avatar vue 2 ([#474](#474)) ([e8600c3](e8600c3)) * **Feed Item Pill:** DLT-1916 remove dt-icon from Feed Item Pill ([#489](#489)) ([bde73c8](bde73c8)) * **Message Input:** DLT-1916 remove dt-icon from message input ([#490](#490)) ([3215116](3215116)) * **Utilities:** DLT-1763 add gap utility class ([#492](#492)) ([835d06f](835d06f))

# [2.159.0-beta.2](dialtone-vue2/v2.159.0-beta.1...dialtone-vue2/v2.159.0-beta.2) (2024-09-12) ### Bug Fixes * **Scrollbar Directive:** NO-JIRA overlayscrollbars missing styles ([#493](#493)) ([d1a88e1](d1a88e1)) * **Tokens:** NO-JIRA keep references in css output ([#487](#487)) ([b019ff6](b019ff6)) ### Documentation * NO-JIRA wrong dialtone-css import on local ([da5f7d6](da5f7d6)) ### Features * **Avatar:** DLT-1916 remove dt-icon from Avatar vue 2 ([#474](#474)) ([e8600c3](e8600c3)) * **Feed Item Pill:** DLT-1916 remove dt-icon from Feed Item Pill ([#489](#489)) ([bde73c8](bde73c8)) * **Message Input:** DLT-1916 remove dt-icon from message input ([#490](#490)) ([3215116](3215116)) * **Utilities:** DLT-1763 add gap utility class ([#492](#492)) ([835d06f](835d06f))

# [3.152.0-beta.2](dialtone-vue3/v3.152.0-beta.1...dialtone-vue3/v3.152.0-beta.2) (2024-09-12) ### Bug Fixes * **Scrollbar Directive:** NO-JIRA overlayscrollbars missing styles ([#493](#493)) ([d1a88e1](d1a88e1)) * **Tokens:** NO-JIRA keep references in css output ([#487](#487)) ([b019ff6](b019ff6)) ### Documentation * NO-JIRA wrong dialtone-css import on local ([da5f7d6](da5f7d6)) ### Features * **Avatar:** DLT-1916 remove dt-icon from Avatar vue 2 ([#474](#474)) ([e8600c3](e8600c3)) * **Feed Item Pill:** DLT-1916 remove dt-icon from Feed Item Pill ([#489](#489)) ([bde73c8](bde73c8)) * **Message Input:** DLT-1916 remove dt-icon from message input ([#490](#490)) ([3215116](3215116)) * **Utilities:** DLT-1763 add gap utility class ([#492](#492)) ([835d06f](835d06f))

ninamarina changed the title ~~remove dt-icon from Avatar vue 2~~ feat(avatar): DLT-1916 remove dt-icon from Avatar vue 2 Aug 26, 2024

ninamarina changed the base branch from remove/dt-icon to remove/dt-icon2 August 27, 2024 14:18

ninamarina force-pushed the dt-icon-vue2 branch from 8331546 to 582a2ec Compare August 27, 2024 14:26

ninamarina changed the base branch from remove/dt-icon2 to remove/dt-icon September 2, 2024 18:28

ninamarina changed the base branch from remove/dt-icon to beta September 2, 2024 18:39

ninamarina force-pushed the dt-icon-vue2 branch from 582a2ec to f79e583 Compare September 2, 2024 18:45

ninamarina changed the base branch from beta to remove/dt-icon September 2, 2024 18:48

ninamarina force-pushed the dt-icon-vue2 branch 2 times, most recently from 2ab73ab to 024355f Compare September 2, 2024 18:52

remove dt-icon from Avatar vue 2

d012dda

ninamarina force-pushed the dt-icon-vue2 branch from 024355f to d012dda Compare September 2, 2024 19:09

ninamarina marked this pull request as ready for review September 3, 2024 13:13

ninamarina requested review from juliodialpad, iropolo, francisrupert and braddialpad as code owners September 3, 2024 13:13

Merge branch 'remove/dt-icon' into dt-icon-vue2

61b6ca8

juliodialpad requested changes Sep 3, 2024

View reviewed changes

fix tests

2f80167

ninamarina force-pushed the dt-icon-vue2 branch from 9bd8cc3 to 2f80167 Compare September 4, 2024 14:15

ninamarina added 4 commits September 4, 2024 11:15

fix tests vue 3

e6e7b61

update size to string

166ffc1

add slot for avatarIcon instead of dynamic component

822c3c0

add slot for avatarIcon instead of dynamic component vue 3

7b32652

ninamarina force-pushed the dt-icon-vue2 branch from 9dd7a58 to 7b32652 Compare September 4, 2024 21:05

update docs

a63d8a2

braddialpad approved these changes Sep 5, 2024

View reviewed changes

braddialpad requested a review from juliodialpad September 5, 2024 19:09

juliodialpad requested changes Sep 5, 2024

View reviewed changes

update docs

9a13d6d

ninamarina force-pushed the dt-icon-vue2 branch from b25c820 to 9a13d6d Compare September 5, 2024 20:52

ninamarina added 2 commits September 5, 2024 17:53

remove tgz file

aed5c03

fix param

14ad61d

ninamarina added the no-visual-test Add this tag when the PR does not need visual testing label Sep 5, 2024

ninamarina and others added 3 commits September 5, 2024 18:01

Update packages/dialtone-vue3/components/avatar/avatar.test.js

b31d23b

Co-authored-by: Julio Ortega <[email protected]>

Update packages/dialtone-vue3/components/avatar/avatar.test.js

7e66277

Co-authored-by: Julio Ortega <[email protected]>

move v-if

1a25704

ninamarina requested a review from juliodialpad September 5, 2024 21:13

juliodialpad approved these changes Sep 5, 2024

View reviewed changes

packages/dialtone-vue2/recipes/item_layout/contact_info/contact_info.vue Outdated Show resolved Hide resolved

Update packages/dialtone-vue2/recipes/item_layout/contact_info/contac…

b4d1ce9

…t_info.vue Co-authored-by: Julio Ortega <[email protected]>

ninamarina merged commit e8600c3 into remove/dt-icon Sep 6, 2024
11 checks passed

ninamarina deleted the dt-icon-vue2 branch September 6, 2024 13:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(avatar): DLT-1916 remove dt-icon from Avatar vue 2 #474

feat(avatar): DLT-1916 remove dt-icon from Avatar vue 2 #474

ninamarina commented Aug 26, 2024 •

edited by jira bot

Loading

ninamarina commented Sep 3, 2024

juliodialpad left a comment

juliodialpad left a comment •

edited

Loading

github-actions bot commented Sep 5, 2024

juliodialpad left a comment

github-actions bot commented Sep 5, 2024

feat(avatar): DLT-1916 remove dt-icon from Avatar vue 2 #474

feat(avatar): DLT-1916 remove dt-icon from Avatar vue 2 #474

Conversation

ninamarina commented Aug 26, 2024 • edited by jira bot Loading

Remove dt-icon from Avatar vue 2

🛠️ Type Of Change

📖 Jira Ticket

📖 Description

💡 Context

ninamarina commented Sep 3, 2024

juliodialpad left a comment

Choose a reason for hiding this comment

juliodialpad left a comment • edited Loading

Choose a reason for hiding this comment

github-actions bot commented Sep 5, 2024

juliodialpad left a comment

Choose a reason for hiding this comment

github-actions bot commented Sep 5, 2024

ninamarina commented Aug 26, 2024 •

edited by jira bot

Loading

juliodialpad left a comment •

edited

Loading